Change in vdsm[master]: virt: add device setup and teardown
mpolednik at redhat.com
mpolednik at redhat.com
Wed Apr 27 11:49:44 UTC 2016
Martin Polednik has posted comments on this change.
Change subject: virt: add device setup and teardown
......................................................................
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/55135/12/tests/vmfakelib.py
File tests/vmfakelib.py:
Line 419: def __init__(self, device, fail_setup=None, fail_teardown=None):
Line 420: self.fail_setup = fail_setup
Line 421: self.fail_teardown = fail_teardown
Line 422: self.device = device
Line 423: self.is_setup = False
> Do we need this?
I was thinking about it. For current tests, it's afaik not needed. Future wise, there is still some value - imagine following scenario:
setup (is_setup = True, was_setup = True, was_teardown = False)
teardown (is_setup = False, was_setup = True, was_teardown = True)
setup (is_setup = True, was_setup = True, was_teardown = True)
Therefore, keeping is_setup leads to slightly more generic code.
Line 424: self.was_setup = False
Line 425: self.was_teardown = False
Line 426:
Line 427: @recorded
--
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list