Change in vdsm[master]: v2v: Detect VM with snapshots
mzamazal at redhat.com
mzamazal at redhat.com
Tue Apr 26 11:28:34 UTC 2016
Milan Zamazal has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56574/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 899:
Line 900:
Line 901: def _add_has_snapshots(vm, params):
Line 902: try:
Line 903: ret = vm.hasCurrentSnapshot()
Does this method exist? I can see it only in tests.
Line 904: except libvirt.libvirtError:
Line 905: logging.exception("Error checking for existing snapshots")
Line 906: else:
Line 907: params['has_snapshots'] = ret > 0
--
To view, visit https://gerrit.ovirt.org/56574
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9aa4de2faff92625cd0de8e3ae2a10a2d58aa823
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list