Change in vdsm[master]: v2v: Detect VM with snapshots

fromani at redhat.com fromani at redhat.com
Tue Apr 26 10:46:55 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: v2v: Detect VM with snapshots
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

codewise seems fine, a couple of questions about the tests? Partial ACK.

https://gerrit.ovirt.org/#/c/56574/1/tests/v2vTests.py
File tests/v2vTests.py:

PS1, Line 383:             if methodname == 'lookupByName':
             :                 # Only active domains
             :                 self.assertEqual(len(vms), 2)
             :             else:  # if methodname == 'lookupByID'
             :                 # Only inactive domains
             :                 self.assertEqual(len(vms), 3)
why is this needed?


PS1, Line 526:         self.assertEqual(len(vms),
             :                          len([x for x in VM_SPECS if not x.active]))
why is this needed?


-- 
To view, visit https://gerrit.ovirt.org/56574
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9aa4de2faff92625cd0de8e3ae2a10a2d58aa823
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list