Change in vdsm[master]: net: OVS driver

phoracek at redhat.com phoracek at redhat.com
Tue Apr 19 11:42:01 UTC 2016


Petr Horáček has posted comments on this change.

Change subject: net: OVS driver
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/55958/5/tests/network/ovs_driver_test.py
File tests/network/ovs_driver_test.py:

Line 35: 
Line 36: def setup_module():
Line 37:     global _openvswitch_init_state_is_up
Line 38:     rc, out, err = execCmd([OVS_CTL, 'status'])
Line 39:     _openvswitch_init_state_is_up = (rc == 0)
> You prefer this? _openvswitch_init_state_is_up = rc == 0
It is more readable with them, I'm just surprised, that it passes pyflakes.
Line 40:     if not _openvswitch_init_state_is_up:
Line 41:         execCmd([OVS_CTL, 'start'])
Line 42: 
Line 43: 


-- 
To view, visit https://gerrit.ovirt.org/55958
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic24a9cea8d50e801de12da1c9cfcd2d195aed684
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list