Change in vdsm[master]: net: OVS driver

edwardh at redhat.com edwardh at redhat.com
Tue Apr 19 11:38:36 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: OVS driver
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/55958/2/lib/vdsm/network/ovs/configurators/vsctl.py
File lib/vdsm/network/ovs/configurators/vsctl.py:

Line 145:         if bridge:
Line 146:             command.append(bridge)
Line 147:         return CommandResultDB(command)
Line 148: 
Line 149:     def show(self):
> Will be 'show' used anywhere? It's output is usable only for human reading,
I'm not sure, I don't even know why I added it.
I'll take it out.
Line 150:         return Command(['show'])
Line 151: 
Line 152:     def add_vlan(self, bridge, vlan, fake_bridge_name=None, may_exist=False):
Line 153:         command = []


-- 
To view, visit https://gerrit.ovirt.org/55958
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic24a9cea8d50e801de12da1c9cfcd2d195aed684
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list