Change in vdsm[master]: agent: Introduction of first_connect event

fromani at redhat.com fromani at redhat.com
Mon Apr 18 12:16:10 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: agent: Introduction of first_connect event
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

-1 for visibility

https://gerrit.ovirt.org/#/c/54753/4/lib/vdsm/virt/guestagent.py
File lib/vdsm/virt/guestagent.py:

Line 307:         ver = _MESSAGE_API_VERSION_LOOKUP.get(cmd, _IMPLICIT_API_VERSION_ZERO)
Line 308:         if ver > self.effectiveApiVersion:
Line 309:             raise GuestAgentUnsupportedMessage(cmd, ver,
Line 310:                                                self.effectiveApiVersion)
Line 311:         self._first_connect.wait()
Unless you have a good reason to keep it this way (please add a comment to explain it), I'd really prefer to have a timeout here.
Line 312:         args['__name__'] = cmd
Line 313:         # TODO: encoding is required only on Python 3. Replace with wrapper
Line 314:         # hiding this difference.
Line 315:         message = (json.dumps(args) + '\n').encode('utf8')


-- 
To view, visit https://gerrit.ovirt.org/54753
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idadf356c4224efa704024c0c7f87295d15899342
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list