Change in vdsm[master]: agent: Guest agent reply capability support
fromani at redhat.com
fromani at redhat.com
Mon Apr 18 12:14:36 UTC 2016
Francesco Romani has posted comments on this change.
Change subject: agent: Guest agent reply capability support
......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/53524/7/lib/vdsm/virt/guestagent.py
File lib/vdsm/virt/guestagent.py:
PS7, Line 182: def _on_completion(self, reply_id):
: with self._completion_lock:
: event = self._completion_events.pop(reply_id, None)
: if event is not None:
: event.set()
:
: @property
: def can_reply(self):
: active = self.isResponsive()
: return active and self.effectiveApiVersion >= _REPLY_CAP_MIN_VERSION
:
: @contextlib.contextmanager
: def _waitable_message(self, wait_timeout, reply_id):
: if self.can_reply and wait_timeout is not None:
: event = threading.Event()
: with self._completion_lock:
: self._completion_events[reply_id] = event
: yield
: event.wait(wait_timeout)
: with self._completion_lock:
: self._completion_events.pop(reply_id, None)
: else:
: yield
nice! could you please add a few tests to exercise these methods? Preferably let's avoid calling private methods in tests.
I'm ok if you do in a later patch, your call.
--
To view, visit https://gerrit.ovirt.org/53524
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I00f2f26ec34728c9ad3599734bca90aa407f3c98
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list