Change in vdsm[master]: virt: Introduction of the GuestAgentEvents class

vfeenstr at redhat.com vfeenstr at redhat.com
Wed Apr 13 10:57:50 UTC 2016


Vinzenz Feenstra has posted comments on this change.

Change subject: virt: Introduction of the GuestAgentEvents class
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/51781/5/lib/vdsm/virt/guestagent.py
File lib/vdsm/virt/guestagent.py:

PS5, Line 166: self.events = GuestAgentEvents(self)
> I'm just worried this causes a reference cycle, making the two objects unco
that's why I originally had used weakref, i might put it back


-- 
To view, visit https://gerrit.ovirt.org/51781
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9dde856aa43bf130e28ce1ebc8cc7dac0341f45
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list