Change in vdsm[master]: agent: Guest agent reply capability support

vfeenstr at redhat.com vfeenstr at redhat.com
Wed Apr 13 10:56:32 UTC 2016


Vinzenz Feenstra has posted comments on this change.

Change subject: agent: Guest agent reply capability support
......................................................................


Patch Set 6:

(2 comments)

https://gerrit.ovirt.org/#/c/53524/6/lib/vdsm/virt/guestagent.py
File lib/vdsm/virt/guestagent.py:

PS6, Line 178: _completion_handlers
> this is nice, but it seems you are adding a flexibility that you don't use 
OK Will do


PS6, Line 183: callable
> How a not-None and not-callable handler could end up there?
I don't know. I was being defensive


-- 
To view, visit https://gerrit.ovirt.org/53524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00f2f26ec34728c9ad3599734bca90aa407f3c98
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list