Change in vdsm[master]: kvmstream: tool for streaming images from libvirt
nsoffer at redhat.com
nsoffer at redhat.com
Sun Apr 10 15:06:10 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: kvmstream: tool for streaming images from libvirt
......................................................................
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/55797/1/kvmstream.py
File kvmstream.py:
Line 30: def parse_arguments():
Line 31: parser = argparse.ArgumentParser()
Line 32: parser.add_argument('args')
Line 33: parser.add_argument('-u', dest='uri',
Line 34: help='Libvirt URI')
This should be required argument
Line 35: parser.add_argument('-s', dest='source', nargs='+',
Line 36: help='Source remote volumes path')
Line 37: parser.add_argument('-d', dest='dest', nargs='+',
Line 38: help='Destination local volumes path')
Line 32: parser.add_argument('args')
Line 33: parser.add_argument('-u', dest='uri',
Line 34: help='Libvirt URI')
Line 35: parser.add_argument('-s', dest='source', nargs='+',
Line 36: help='Source remote volumes path')
This should be required argument
Line 37: parser.add_argument('-d', dest='dest', nargs='+',
Line 38: help='Destination local volumes path')
Line 39: return parser.parse_args(sys.argv)
Line 40:
Line 34: help='Libvirt URI')
Line 35: parser.add_argument('-s', dest='source', nargs='+',
Line 36: help='Source remote volumes path')
Line 37: parser.add_argument('-d', dest='dest', nargs='+',
Line 38: help='Destination local volumes path')
This should be required argument
Line 39: return parser.parse_args(sys.argv)
Line 40:
Line 41:
Line 42: def write_output(msg):
Line 46:
Line 47: def init_progres():
Line 48: global elapsed_time
Line 49: write_output('[ %d.0] Opening the source -i libvirt\n' % elapsed_time)
Line 50: elapsed_time = elapsed_time + 1
This is left over from fake progress code
Line 51: write_output('[ %d.0] Creating an overlay to protect\n' % elapsed_time)
Line 52: elapsed_time = elapsed_time + 1
Line 53:
Line 54:
Line 52: elapsed_time = elapsed_time + 1
Line 53:
Line 54:
Line 55: def finish_progress():
Line 56: global elapsed_time
We should use real time here
Line 57: write_output('[ %d.0] Creating output metadata\n' % elapsed_time)
Line 58: write_output('[ %d.0] Finishing off\n' % elapsed_time)
Line 59:
Line 60:
--
To view, visit https://gerrit.ovirt.org/55797
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d95c3bf4b2605e71f899171259d4721204eb8e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list