Change in vdsm[master]: kvmstream: tool for streaming images from libvirt

nsoffer at redhat.com nsoffer at redhat.com
Thu Apr 7 14:04:51 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: kvmstream: tool for streaming images from libvirt
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/55797/1/kvmstream.py
File kvmstream.py:

Line 69:     vol.download(stream, 0, 0, 0)
Line 70:     write_output('    (0/100%%)\r')
Line 71:     counter = 0
Line 72:     while pos < size:
Line 73:         buf = s.recv(1024)
> I am not sure,
We use 1M in ovirt-imageio and vdsm when copying images. We should have a default and command line option to change it.
Line 74:         f.write(buf)
Line 75:         f.flush()
Line 76:         if not pos % jump:
Line 77:             counter = counter + 1


-- 
To view, visit https://gerrit.ovirt.org/55797
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d95c3bf4b2605e71f899171259d4721204eb8e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list