Change in vdsm[master]: migration: Add retry on full capacity

mbetak at redhat.com mbetak at redhat.com
Tue Apr 5 11:44:59 UTC 2016


Martin Betak has posted comments on this change.

Change subject: migration: Add retry on full capacity
......................................................................


Patch Set 23:

(2 comments)

https://gerrit.ovirt.org/#/c/52799/23/vdsm/virt/migration.py
File vdsm/virt/migration.py:

PS23, Line 338: retry_timeout
> if you move it to line 366 it doesn't get called when everything is smooth.
Done


PS23, Line 673: is_retry_error
> since you have response.is_error() at line 399 I don't think it conveys any
This helper is also being used by dependant patches in API.py. I'd really hate for so many different parts of the code to be dependent on specific error code. 

And the comment is in place just to clarify *why* the helper is used and in my opinion doesn't make the helper any less useful. But if you insist, I would very much rather remove the comment than this helper :-)


-- 
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list