Change in vdsm[master]: net: native ovs [7]: configure basic ovs nets and bonds

edwardh at redhat.com edwardh at redhat.com
Tue Apr 5 11:43:38 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: native ovs [7]: configure basic ovs nets and bonds
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/55307/5/lib/vdsm/network/ovs/configurators/api.py
File lib/vdsm/network/ovs/configurators/api.py:

Line 32: class Command(object):
Line 33:     """An OVS command which is to be executed in Transaction."""
Line 34: 
Line 35: 
Line 36: class API(object):
What about using abc?
Line 37:     """Abstact class for configurator implementations.
Line 38: 
Line 39:     Each method returns Command instance.
Line 40:     """


-- 
To view, visit https://gerrit.ovirt.org/55307
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic779d8798e02b5e5eae514e111ab2a7e2ad2e786
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list