Change in vdsm[master]: storage: Move mount module to vdsm storage lib.

nsoffer at redhat.com nsoffer at redhat.com
Sun Apr 3 12:00:07 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: storage: Move mount module to vdsm storage lib.
......................................................................


Patch Set 9:

(8 comments)

https://gerrit.ovirt.org/#/c/55292/9/lib/vdsm/storage/Makefile.am
File lib/vdsm/storage/Makefile.am:

Line 26: 	constants.py \
Line 27: 	exception.py \
Line 28: 	persistent.py \
Line 29: 	securable.py \
Line 30:         mount.py \
Must use tab here, not spaces.
Line 31: 	sync.py \


https://gerrit.ovirt.org/#/c/55292/9/tests/mkimageTests.py
File tests/mkimageTests.py:

Line 34
Line 35
Line 36
Line 37
Line 38
Import should be here.


Line 38: 
Line 39: from vdsm import udevadm
Line 40: from vdsm.commands import execCmd
Line 41: from vdsm.utils import stopwatch
Line 42: from vdsm import storage
Move before "from vdsm import udevadm"

Less specific import come before more specific imports.
Line 43: import mkimage
Line 44: 
Line 45: 
Line 46: @expandPermutations


https://gerrit.ovirt.org/#/c/55292/9/tests/mountTests.py
File tests/mountTests.py:

Line 25
Line 26
Line 27
Line 28
Line 29
"from vdsm" imports should be grouped here (sorted)


Line 32: 
Line 33: from testlib import VdsmTestCase as TestCaseBase
Line 34: from testlib import namedTemporaryDir, expandPermutations, permutations
Line 35: from storage.misc import execCmd
Line 36: import vdsm.storage.mount as mount
from vdsm.storage import mount

And move it up to the "from vdsm" imports.
Line 37: from testValidation import checkSudo
Line 38: import monkeypatch
Line 39: 
Line 40: FLOPPY_SIZE = (2 ** 20) * 4


https://gerrit.ovirt.org/#/c/55292/9/vdsm/mkimage.py
File vdsm/mkimage.py:

Line 31:     DISKIMAGE_USER, DISKIMAGE_GROUP
Line 32: from vdsm.constants import P_VDSM_RUN
Line 33: from vdsm.commands import execCmd
Line 34: from vdsm.utils import rmFile
Line 35: from vdsm import storage
Move before "from vdsm.constants ..." (less specific before more specific)
Line 36: from storage.fileUtils import resolveUid, resolveGid
Line 37: 
Line 38: _P_PAYLOAD_IMAGES = os.path.join(P_VDSM_RUN, 'payload')
Line 39: 


https://gerrit.ovirt.org/#/c/55292/9/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 37: from vdsm import udevadm
Line 38: from vdsm import utils
Line 39: from vdsm.storage import exception as se
Line 40: from vdsm.storage import sync
Line 41: from vdsm.storage import mount
Move under "from vdsm.storage import exception"
Line 42: from vdsm.storage.mount import MountError
Line 43: 
Line 44: import fileUtils
Line 45: import fileSD


Line 38: from vdsm import utils
Line 39: from vdsm.storage import exception as se
Line 40: from vdsm.storage import sync
Line 41: from vdsm.storage import mount
Line 42: from vdsm.storage.mount import MountError
Leave it here, we need to eliminate this import later.
Line 43: 
Line 44: import fileUtils
Line 45: import fileSD
Line 46: import iscsi


-- 
To view, visit https://gerrit.ovirt.org/55292
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ee9fab87abcabc469c15256ba12386112a100e0
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list