Change in vdsm[master]: net: canonicalize 'switch' in nets and bonds
phoracek at redhat.com
phoracek at redhat.com
Sun Apr 3 11:49:48 UTC 2016
Petr Horáček has posted comments on this change.
Change subject: net: canonicalize 'switch' in nets and bonds
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/55495/5/lib/vdsm/network/canonicalize.py
File lib/vdsm/network/canonicalize.py:
Line 105: if 'dhcpv6' not in data:
Line 106: data['dhcpv6'] = False
Line 107:
Line 108:
Line 109: def _canonicalize_switch(data):
> Well... you do use it in later patches.
the second point convinced me.
Line 110: if 'switch' not in data:
--
To view, visit https://gerrit.ovirt.org/55495
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71b6c0ae1a0027bbacf7da7dc8e4cd2926cbcb7d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list