Change in vdsm[master]: hooks: Add fcoe hook

danken at redhat.com danken at redhat.com
Sun Apr 3 06:06:14 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: hooks: Add fcoe hook
......................................................................


Patch Set 14:

(2 comments)

https://gerrit.ovirt.org/#/c/55029/14/vdsm_hooks/fcoe/fcoe_before_network_setup.py
File vdsm_hooks/fcoe/fcoe_before_network_setup.py:

Line 67:            and hooking.tobool(config.networks[net]['custom'].get('fcoe')):
Line 68:             configured[net] = config.networks[net].get('nic')
Line 69: 
Line 70:     setup_nets_config = hooking.read_json()
Line 71:     changed_networks = setup_nets_config['request']['networks']
> It's a little bit complicated.
I prefer to accept fcoe on top of a bond, with a proper warning in documentation. Otherwise, we block people's valid use case.

This is a hook, to be used by people who should know what they are doing.
Line 72: 
Line 73:     for net in changed_networks:
Line 74:         if ('custom' in changed_networks[net].keys()) \
Line 75:            and hooking.tobool(changed_networks[net]['custom'].get('fcoe')):


PS14, Line 95: Remove file in _fail hook if services are not able to start
> Yes, ideally recent changes should be rolled back. I hope saving list of fi
your suggested rollback is not bullet-proof: it does not handle a Vdsm/host crash while the hook is running, but I think it is fair enough.

You can even not handle it right now, but please leave a legible TODO line.


-- 
To view, visit https://gerrit.ovirt.org/55029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad2faed7205ca08801132df072b469dbe781318c
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Pavel Zhukov <pzhukov at redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list