Change in vdsm[master]: storage: Move mount module to vdsm storage lib.

mlipchuk at redhat.com mlipchuk at redhat.com
Sun Apr 3 04:52:27 UTC 2016


Maor Lipchuk has posted comments on this change.

Change subject: storage: Move mount module to vdsm storage lib.
......................................................................


Patch Set 7:

(2 comments)

https://gerrit.ovirt.org/#/c/55292/7/tests/mkimageTests.py
File tests/mkimageTests.py:

Line 38: 
Line 39: from vdsm import udevadm
Line 40: from vdsm.commands import execCmd
Line 41: from vdsm.utils import stopwatch
Line 42: import vdsm.storage
> Use:
Done
Line 43: import mkimage
Line 44: 
Line 45: 
Line 46: @expandPermutations


Line 168:         Requires root permissions for writing into the floppy image.
Line 169:         """
Line 170:         floppy = mkimage.mkFloppyFs("vmId_floppy", self.files, label)
Line 171:         self.assertTrue(os.path.exists(floppy))
Line 172:         m = vdsm.storage.mount.Mount(floppy, self.workdir)
> Don't do such changes - use correct import to avoid these changes.
Done
Line 173:         m.mount(mntOpts='loop')
Line 174:         try:
Line 175:             self._check_content(checkPerms=False)
Line 176:             self._check_label(floppy, label)


-- 
To view, visit https://gerrit.ovirt.org/55292
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ee9fab87abcabc469c15256ba12386112a100e0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list