Change in vdsm[master]: hsm: Remove support for size in sectors as int

danken at redhat.com danken at redhat.com
Fri Oct 16 21:11:31 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: hsm: Remove support for size in sectors as int
......................................................................


hsm: Remove support for size in sectors as int

We used to support volume size either as number of sectors using int, or
as number of bytes using a string. Engine is using size in bytes since
first git commit. Hosted engine setup is also using size in bytes.  We
don't know about old code using number of sectors.

This patch removes the support for size in sectors.  To prevent
incorrect usage we raise InvalidParameterException if called with an
integer.

Change-Id: I52957eec163973fd60a95a9bf523131f3c83a9da
Bug-Url: https://bugzilla.redhat.com/1221603
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/47381
Reviewed-by: Adam Litke <alitke at redhat.com>
Continuous-Integration: Jenkins CI
---
M client/vdsClient.py
M lib/vdsm/constants.py.in
M vdsm/rpc/vdsmapi-schema.json
M vdsm/storage/hsm.py
4 files changed, 12 insertions(+), 13 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/47381
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I52957eec163973fd60a95a9bf523131f3c83a9da
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list