Change in vdsm[master]: hsm: Remove support for size in sectors as int

danken at redhat.com danken at redhat.com
Fri Oct 16 21:11:04 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: hsm: Remove support for size in sectors as int
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/47381/3/client/vdsClient.py
File client/vdsClient.py:

Line 1064
Line 1065
Line 1066
Line 1067
Line 1068
> vdsClient accepts size in GiB and this was not changed in this patch, so it
It is not internal, as old vdsClient scripts are still in the wild, and they may be using int to call createVolume.

Engine >= 3.0 does not use int, but vdsClient just might.


-- 
To view, visit https://gerrit.ovirt.org/47381
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52957eec163973fd60a95a9bf523131f3c83a9da
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list