Change in vdsm[master]: net: tests: test network's iface

phoracek at redhat.com phoracek at redhat.com
Fri Nov 27 14:12:18 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: net: tests: test network's iface
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/48366/5/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 246:         if assert_in_running_conf and config is not None:
Line 247:             self.assertIn(networkName, config.networks)
Line 248:             if bridged is not None:
Line 249:                 self.assertEqual(network_config.get('bridged'), bridged)
Line 250:         if network_config['bridged']:
> a line above we do not assume that 'bridge' in network_config. we should do
i think that bridge should be reported in every case. should i test its presence explicitly?
Line 251:             expected_iface = networkName
Line 252:         elif network_config.get('vlan') is not None:
Line 253:             expected_iface = '%s.%s' % (physical_iface,
Line 254:                                         network_config.get('vlan'))


-- 
To view, visit https://gerrit.ovirt.org/48366
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If45fb63247b5e5b21721a23d8781a4ed80e58932
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list