Change in vdsm[master]: net: tests: test network's iface
danken at redhat.com
danken at redhat.com
Fri Nov 27 11:09:23 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: net: tests: test network's iface
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/48366/5/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 250: network_config['bridged']
a line above we do not assume that 'bridge' in network_config. we should do the same here.
if network_config.get('bridged', True)
--
To view, visit https://gerrit.ovirt.org/48366
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If45fb63247b5e5b21721a23d8781a4ed80e58932
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list