Change in vdsm[master]: vdsm.conf: Add drop-in dir

ybronhei at redhat.com ybronhei at redhat.com
Thu Nov 19 12:00:13 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm.conf: Add drop-in dir
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Thanks! lets keep only vdsm.conf.d - and lets create the directory during installation - ovirt-host-deploy needs to be updated accordingly as it installs some configs in vdsm.conf

https://gerrit.ovirt.org/#/c/48317/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 455: config = ConfigParser.ConfigParser()
Line 456: set_defaults(config)
Line 457: 
Line 458: # Read from teh config file first
Line 459: vdsmconf [os.path.join('@CONFDIR@', 'vdsm.conf')]
s/teh/the
did you forget the '=' ?
Line 460: config.read([os.path.join('@CONFDIR@', 'vdsm.conf')])
Line 461: 
Line 462: # Also read files in the drop-in dir
Line 463: vdsmconfd = vdsmconf + '.d')


Line 461: 
Line 462: # Also read files in the drop-in dir
Line 463: vdsmconfd = vdsmconf + '.d')
Line 464: if os.path.exists(vdsmconfd):
Line 465:     config.read(sorted(glob(vdsmconfd + "/*.conf")))
if it overrides things under vdsm.conf? we should have one method... leave both makea it too confusing imo
Line 466: 
Line 467: if __name__ == '__main__':


-- 
To view, visit https://gerrit.ovirt.org/48317
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I707a1865e8d60dc4dcdc0e681b52c07c75f1c409
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch <fabiand at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list