Change in vdsm[master]: net: ovs: remove initial nic ip, dont touch unchanged networks

ibarkan at redhat.com ibarkan at redhat.com
Thu Nov 19 11:47:47 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks
......................................................................


Patch Set 11: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/46692/11/vdsm_hooks/ovs/ovs_before_network_setup_ip.py
File vdsm_hooks/ovs/ovs_before_network_setup_ip.py:

Line 69: ip_config
this structural change is unrelated to the change in behavior and should be moved tot a later patch


Line 117: _drop_ip_config
I don't understand, this is not what this function really does


Line 133: 
Line 134:     ip_config_to_set = {}
Line 135:     ip_config_to_remove = {}
Line 136: 
Line 137:     for net, attrs in nets.iteritems():
what do you mean by newly attached nics?
Line 138:         if 'remove' in attrs:  # if network was removed
Line 139:             # remove network's IP configuration (running dhclient)
Line 140:             ip_config = _gather_ip_config(init_nets[net])
Line 141:             ip_config_to_remove[ip_config.top_dev] = ip_config


-- 
To view, visit https://gerrit.ovirt.org/46692
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9682c75cfb79f75b64cb8cb587fc3ed01cf15c8
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list