Change in vdsm[master]: v2v: _add_disk_info hides error when probbing for disk infor...

shavivi at redhat.com shavivi at redhat.com
Wed Nov 18 13:40:38 UTC 2015


Shahar Havivi has posted comments on this change.

Change subject: v2v: _add_disk_info hides error when probbing for disk information
......................................................................


Patch Set 2:

Getting the disk information is mandatory for importing VM to allocate the disk size in vdsm domain.
I do agree that we don't need to fail the request...
We will handle it in the engine - 
I will revert that patch and return the test that check for non existing storage

-- 
To view, visit https://gerrit.ovirt.org/48707
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ac8f724952c475445e0d0481b44a679006f7fa4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list