Change in vdsm[master]: v2v: _add_disk_info hides error when probbing for disk infor...

nsoffer at redhat.com nsoffer at redhat.com
Wed Nov 18 13:32:34 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: v2v: _add_disk_info hides error when probbing for disk information
......................................................................


Patch Set 2: Code-Review-1

Please explain how the error is hidden (we log it), and why failure to get information about one disk should fail the entire request.

We have see issues in the field when certain vms fail to get disk info or even get xml for the vm, and in the same time other vms return complete info.

When you collect information about multiple vms, you do't want to fail the entire request because there was trouble getting info about one vm.

What we need is to return all the info we know, and display it in the engine side. If you want to information about error in the engine side, collect the errors and return them as part of the request.

-- 
To view, visit https://gerrit.ovirt.org/48707
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ac8f724952c475445e0d0481b44a679006f7fa4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list