Change in vdsm[master]: stomp: message tracking do not clean properly

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Tue Nov 17 15:41:29 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: stomp: message tracking do not clean properly
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/48616/2/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 319:     Sends message to all subscribes that subscribed to destination.
Line 320:     """
Line 321:     def send(self, message, destination=stomp.LEGACY_SUBSCRIPTION_ID_RESPONSE):
Line 322:         resp = json.loads(message)
Line 323:         response_id = resp.get("id")
> thanks for the updates!
it is not possible not to have "id" object. jsonrpc 2.0 restriction. If there isn't one it is a bug.
Line 324: 
Line 325:         try:
Line 326:             destination = self._req_dest[response_id]
Line 327:             del self._req_dest[response_id]


Line 328:         except KeyError:
Line 329:             self.log.warn("Missing destination for %s id", response_id)
Line 330: 
Line 331:         try:
Line 332:             connections = self._sub_map[destination]
> If we had a KeyError in line 326,
I thought about it. It would be ok to return after 329. I decided to keep the code as it was before without return there.
Line 333:         except KeyError:
Line 334:             self.log.warn("Attempt to reply to unknown destination %s",
Line 335:                           destination)
Line 336:             return


-- 
To view, visit https://gerrit.ovirt.org/48616
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ca7c7589fea2d7ad5a477123b14df17924fda0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list