Change in vdsm[master]: stomp: message tracking do not clean properly
fromani at redhat.com
fromani at redhat.com
Tue Nov 17 15:33:47 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: stomp: message tracking do not clean properly
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/48616/2/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 319: Sends message to all subscribes that subscribed to destination.
Line 320: """
Line 321: def send(self, message, destination=stomp.LEGACY_SUBSCRIPTION_ID_RESPONSE):
Line 322: resp = json.loads(message)
Line 323: response_id = resp.get("id")
thanks for the updates!
A question: as per semantics of dict.get, response_id can now be None:
>>> d = {}
>>> print d.get('a')
None
>>>
Could this be a problem? Does the comment in the old code refers to this "id" field or something else completely?
Line 324:
Line 325: try:
Line 326: destination = self._req_dest[response_id]
Line 327: del self._req_dest[response_id]
--
To view, visit https://gerrit.ovirt.org/48616
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2ca7c7589fea2d7ad5a477123b14df17924fda0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list