Change in vdsm[master]: Adding python3 run for nosetests

nsoffer at redhat.com nsoffer at redhat.com
Tue Nov 10 12:47:55 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: Adding python3 run for nosetests
......................................................................


Patch Set 8: -Code-Review

(1 comment)

https://gerrit.ovirt.org/#/c/48051/8/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 19: #
Line 20: 
Line 21: from __future__ import absolute_import
Line 22: import os
Line 23: from six.moves import configparser as ConfigParser
> I share Yaniv's approach, and would like to see that very first patch as sh
It is better to get it right in one patch, and the rename is trivial.

I think we are wasting time on reviewing and verifying intermediate patches that we don't want, but I will not block this.
Line 24: import textwrap
Line 25: 
Line 26: parameters = [
Line 27:     # Section: [vars]


-- 
To view, visit https://gerrit.ovirt.org/48051
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83355cce2af9125e6f017017905056956cd17081
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list