Change in vdsm[master]: Adding python3 run for nosetests
danken at redhat.com
danken at redhat.com
Tue Nov 10 12:40:28 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: Adding python3 run for nosetests
......................................................................
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/48051/8/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 19: #
Line 20:
Line 21: from __future__ import absolute_import
Line 22: import os
Line 23: from six.moves import configparser as ConfigParser
> starting with the minimal change first
I share Yaniv's approach, and would like to see that very first patch as short as possible.
Plenty of rename patches should follow promptly.
Line 24: import textwrap
Line 25:
Line 26: parameters = [
Line 27: # Section: [vars]
https://gerrit.ovirt.org/#/c/48051/8/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 633: """
Line 634:
Line 635: # Moving import here so that import utils over python3 will work. Once
Line 636: # python3-cpopen will be available this import should return to top
Line 637: from cpopen import CPopen
> keep it minimal for now - but I'll use the compat trick in following patch
I like the idea of moving CPopen to compat in a separate patch, possibly following the umask removal patch.
Line 638:
Line 639: command = cmdutils.wrap_command(command, with_ioclass=ioclass,
Line 640: ioclassdata=ioclassdata, with_nice=nice,
Line 641: with_setsid=setsid, with_sudo=sudo,
https://gerrit.ovirt.org/#/c/48051/8/vdsm.spec.in
File vdsm.spec.in:
Line 96: BuildRequires: rpm-python
Line 97: BuildRequires: python-blivet
Line 98: BuildRequires: python3-nose
Line 99: BuildRequires: python3-six
Line 100: BuildRequires: python-six
dup
Line 101:
Line 102: # Autotools BuildRequires
Line 103: %if 0%{?enable_autotools}
Line 104: BuildRequires: autoconf
--
To view, visit https://gerrit.ovirt.org/48051
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I83355cce2af9125e6f017017905056956cd17081
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list