Change in vdsm[master]: net: use libvirt to manage bridge mac learning

ibarkan at redhat.com ibarkan at redhat.com
Mon Nov 2 07:01:22 UTC 2015


Ido Barkan has uploaded a new change for review.

Change subject: net: use libvirt to manage bridge mac learning
......................................................................

net: use libvirt to manage bridge mac learning

In late kernels, this can lead for performance boost, by eliminating
unneeded packet flooding in the LAN and also allow the kernel to shut
down promiscuous mode for bridge ports.
see: https://libvirt.org/formatnetwork.html#elementsConnect

Change-Id: I4d52d90587c79e992a6466f3f98ee9c877cc36f4
Signed-off-by: Ido Barkan <ibarkan at redhat.com>
---
M vdsm/network/configurators/libvirt.py
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/47935/1

diff --git a/vdsm/network/configurators/libvirt.py b/vdsm/network/configurators/libvirt.py
index a88ded7..85490ba 100644
--- a/vdsm/network/configurators/libvirt.py
+++ b/vdsm/network/configurators/libvirt.py
@@ -46,7 +46,8 @@
     <network>
         <name>vdsm-awesome_net</name>
 
-        <forward mode='bridge'/><bridge name='awesome_net'/> ||
+        <forward mode='bridge'/>
+            <bridge name='awesome_net' macTableManager="libvirt"/> ||
         <forward mode='passthrough'><interface dev='incredible'/></forward>
     </network>
 
@@ -54,6 +55,8 @@
     according to net if bridged or bridgeless this
     determines respectively the presence of bridge element
     or interface subelement.
+    For bridged networks, libvirt can manage the forwarding table of the
+    bridge, which can enhance performance for the host.
     """
 
     netName = netinfo.LIBVIRT_NET_PREFIX + network
@@ -75,7 +78,8 @@
     root.append(nameElem)
     root.append(forwardElem)
     if bridged:
-        root.append(EtreeElement('bridge', name=network))
+        root.append(
+            EtreeElement('bridge', name=network, macTableManager='libvirt'))
     else:
         forwardElem.append(EtreeElement('interface', dev=iface))
     return etree.tostring(root)


-- 
To view, visit https://gerrit.ovirt.org/47935
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d52d90587c79e992a6466f3f98ee9c877cc36f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>


More information about the vdsm-patches mailing list