Change in vdsm[master]: api: Adding dns as additional field for setupNetworks ifcfg:...

ibarkan at redhat.com ibarkan at redhat.com
Mon Nov 2 06:51:02 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: api: Adding dns as additional field for setupNetworks ifcfg: Updating ifcfg file with DNSs
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/47843/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-10-29 15:26:07 +0200
Line 4: Commit:     Genadi Chereshnya <gcheresh at redhat.com>
Line 5: CommitDate: 2015-10-29 15:26:07 +0200
Line 6: 
Line 7: api: Adding dns as additional field for setupNetworks
> subject line should be a single line, such as:
I would also prefix with "net:" it is later easy to search on commit messages this way.
Line 8: ifcfg: Updating ifcfg file with DNSs
Line 9: 
Line 10: Adding DNSs to the setupNetwork command
Line 11: 


https://gerrit.ovirt.org/#/c/47843/1/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:

Line 538:             elif ipv6.dhcpv6:
Line 539:                 cfg += 'DHCPV6C=yes\n'
Line 540:             cfg += 'IPV6_AUTOCONF=%s\n' % _to_ifcfg_bool(ipv6.ipv6autoconf)
Line 541:         if dnss:
Line 542:             for i, dns in enumerate(dnss):
> how many are supported by initscrtips? unsupported?
only 2.
https://www.centos.org/docs/5/html/Deployment_Guide-en-US/s1-networkscripts-interfaces.html
So ifcfg can blow up here if someone requested more.
for other configurators, this depends on the support of /etc/resolv.conf
Line 543:                 cfg += 'DNS' + str(i+1) + '=%s\n' % dns
Line 544: 
Line 545:         BLACKLIST = ['TYPE', 'NAME', 'DEVICE', 'VLAN', 'bondingOptions',
Line 546:                      'force', 'blockingdhcp', 'custom',


-- 
To view, visit https://gerrit.ovirt.org/47843
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9ea16d033cc07ef10c05868da3e6b4bcee56f74
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list