Change in vdsm[master]: migration: Support SPICE seamless migration over NAT
fromani at redhat.com
fromani at redhat.com
Wed May 27 11:33:08 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: migration: Support SPICE seamless migration over NAT
......................................................................
Patch Set 2:
(1 comment)
looks good, modulo the VNC concerns Michal raised.
But how and where this code is going to be used?
https://gerrit.ovirt.org/#/c/41223/2/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 349: params = {VIR_MIGRATE_PARAM_URI: str(muri),
Line 350: VIR_MIGRATE_PARAM_BANDWIDTH: maxBandwidth}
Line 351: if self._consoleAddress:
Line 352: params[VIR_MIGRATE_PARAM_GRAPHICS_URI] = \
Line 353: 'spice://%s' % self._consoleAddress
> all looks good....except I wonder how does this behave with VNC. We have to
note that SourceThread can easily check the graphics device the VM is using:
self._vm.hasSpice
Line 354:
Line 355: flags = (libvirt.VIR_MIGRATE_LIVE |
Line 356: libvirt.VIR_MIGRATE_PEER2PEER |
Line 357: (libvirt.VIR_MIGRATE_TUNNELLED if
--
To view, visit https://gerrit.ovirt.org/41223
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7b2b765c62aaf1cc694990205b518558e808516
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list