Change in vdsm[master]: migration: Support SPICE seamless migration over NAT

mskrivan at redhat.com mskrivan at redhat.com
Wed May 27 10:16:47 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: migration: Support SPICE seamless migration over NAT
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/41223/2/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 349:             params = {VIR_MIGRATE_PARAM_URI: str(muri),
Line 350:                       VIR_MIGRATE_PARAM_BANDWIDTH: maxBandwidth}
Line 351:             if self._consoleAddress:
Line 352:                 params[VIR_MIGRATE_PARAM_GRAPHICS_URI] = \
Line 353:                     'spice://%s' % self._consoleAddress
all looks good....except I wonder how does this behave with VNC. We have to check that:-/
Line 354: 
Line 355:             flags = (libvirt.VIR_MIGRATE_LIVE |
Line 356:                      libvirt.VIR_MIGRATE_PEER2PEER |
Line 357:                      (libvirt.VIR_MIGRATE_TUNNELLED if


-- 
To view, visit https://gerrit.ovirt.org/41223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7b2b765c62aaf1cc694990205b518558e808516
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list