Change in vdsm[master]: Memory Hotplug for vm

ofrenkel at redhat.com ofrenkel at redhat.com
Wed May 27 09:13:57 UTC 2015


Omer Frenkel has posted comments on this change.

Change subject: Memory Hotplug for vm
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/40549/3/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:

Line 239: 
Line 240:     def __init__(self, conf, log, **kwargs):
Line 241:         super(Memory, self).__init__(conf, log, **kwargs)
Line 242:         # we get size in mb and send in kb
Line 243:         self.size = int(kwargs.get('size')) * 1024
> I think you mentioned that due some limitation down the stack, each size sh
256mb, enforced by the backend, you can see this at
https://gerrit.ovirt.org/#/c/35081/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotSetAmountOfMemoryCommand.java [line 84]
Line 244:         self.node = kwargs.get('node')
Line 245: 
Line 246:     def getXML(self):
Line 247:         """


Line 242:         # we get size in mb and send in kb
Line 243:         self.size = int(kwargs.get('size')) * 1024
Line 244:         self.node = kwargs.get('node')
Line 245: 
Line 246:     def getXML(self):
> can you please add one unit test for getXML (in tests/deviceTests.py) ?
Done
Line 247:         """
Line 248:         <memory model='dimm'>
Line 249:             <target>
Line 250:                 <size unit='KiB'>524287</size>


-- 
To view, visit https://gerrit.ovirt.org/40549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2cdea311c3ff010b1d232abf6cc0a7d60937b1e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list