Change in vdsm[master]: Memory Hotplug for vm

fromani at redhat.com fromani at redhat.com
Tue May 26 14:12:45 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: Memory Hotplug for vm
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/40549/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2175:         self._devices[hwclass.MEMORY].append(device)
Line 2176:         with self._confLock:
Line 2177:             self.conf['devices'].append(memParams)
Line 2178:         self.saveState()
Line 2179:         self._getUnderlyingMemoryDeviceInfo()
> Do we have guarantees that this will see the updated XML?
This is not a problem of this patch specifically, but the point is to make sure that _getUnderlyingMemoryDeviceInfo will get an up-to-date XML from libvirt.

I think this is true, once attachDevice returns, the internal domain representation inside libvirtd (hence the XML) should up to date and should reflect the changes.

I'm asking here because we had synchronization bugs in the recent past, like

https://bugzilla.redhat.com/show_bug.cgi?id=1202719 

But I don't have any specific reason to suspect this specific code path.
Line 2180: 
Line 2181:         hooks.after_memory_hotplug(deviceXml)
Line 2182: 
Line 2183:         return {'status': doneCode, 'vmList': self.status()}


-- 
To view, visit https://gerrit.ovirt.org/40549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2cdea311c3ff010b1d232abf6cc0a7d60937b1e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list