Change in vdsm[master]: status: adding elapsed time in millis

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Fri May 22 10:54:40 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: status: adding elapsed time in millis
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/40904/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 403: 
Line 404:     def _get_elapsed_time_in_millis(self):
Line 405:         return str(
Line 406:             int(round(time.time() * 1000)) -
Line 407:             int(round(self._startTime * 1000))
> We are relying here on _startTime which do not use monotonic_time. I did no
hm...need to also consider teh migration case twhen the dst host has wrong clock (rare, but does happen and we shouldn't explode, just fail)
Line 408:         )
Line 409: 
Line 410:     lastStatus = property(_get_lastStatus, _set_lastStatus)
Line 411: 


-- 
To view, visit https://gerrit.ovirt.org/40904
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38727e0eac7cb29c1dc7c9696568540b6545461c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list