Change in vdsm[master]: status: adding elapsed time in millis

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Thu May 21 13:51:00 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: status: adding elapsed time in millis
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/40904/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 407: 
Line 408:     def _get_elapsed_time_in_millis(self):
Line 409:         return str(
Line 410:             int(round(time.time() * 1000)) -
Line 411:             int(round(self._startTime * 1000))
> What were the arguments in this conversation? why did you decided to not us
It is not about making the life easier it is about solving the problem in correct way.

The assumption is that we do not persist information on which we order status updates so we need to solve crash/restart of vdsm and engine. The same issue we have when migrating a vm to different host. After long conversation we have decided to use _startTime which seems to solve above issues.

If you think that using counter would solve the issues with having the same code complexity please provide your solution.
Line 412:         )
Line 413: 
Line 414:     lastStatus = property(_get_lastStatus, _set_lastStatus)
Line 415: 


-- 
To view, visit https://gerrit.ovirt.org/40904
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38727e0eac7cb29c1dc7c9696568540b6545461c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list