Change in vdsm[master]: Adding unittests for caps.py

danken at redhat.com danken at redhat.com
Thu May 21 09:12:35 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: Adding unittests for caps.py
......................................................................


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/41077/12/tests/cpu_map.xml
File tests/cpu_map.xml:

Line 1: <!--  Taken from /usr/share/libvirt/cpu_map.xml
Line 2:       Needed for capsTests.testGetAllCpuModels to have a predictable
Line 3:       source of data to test the parsing of the file -->
> why not build-depend on libvirt and just read from the system data? We acce
I prefer to ship a copy since a minor update of libvirt (adding a cpu type) would make the test break.
Line 4: <cpus>
Line 5:   <arch name='x86'>
Line 6:     <!-- vendor definitions -->
Line 7:     <vendor name='Intel' string='GenuineIntel'/>


-- 
To view, visit https://gerrit.ovirt.org/41077
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86c2203bf245ba209e10b0905ae1090835408201
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list