Change in vdsm[master]: Adding unittests for caps.py

fromani at redhat.com fromani at redhat.com
Thu May 21 08:38:13 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: Adding unittests for caps.py
......................................................................


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/41077/12/tests/capsTests.py
File tests/capsTests.py:

Line 243:         capsData = self._readCaps("caps_libvirt_intel_i73770_nosnap.out")
Line 244:         result = caps._getEmulatedMachines('x86_64', capsData)
Line 245:         expected = ['rhel6.5.0', 'pc', 'rhel6.4.0', 'rhel6.3.0', 'rhel6.2.0',
Line 246:                     'rhel6.1.0', 'rhel6.0.0', 'rhel5.5.0', 'rhel5.4.4',
Line 247:                     'rhel5.4.0']
> but _getEmulatedMachines() returns a list...
Fair point indeed, but do we care about the actual sequence type or we just need an iterable?

Anyway, feel free to scrap my comment if you feel it confusing.
Line 248:         self.assertEqual(expected, result)
Line 249: 
Line 250:     def test_getNumaTopology(self):
Line 251:         capsData = self._readCaps("caps_libvirt_intel_i73770_nosnap.out")


-- 
To view, visit https://gerrit.ovirt.org/41077
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86c2203bf245ba209e10b0905ae1090835408201
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list