Change in vdsm[master]: events: vm status notifications

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Tue May 19 20:41:38 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: events: vm status notifications
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/38937/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 866:     def _set_lastStatus(self, value):
Line 867:         with self._statusLock:
Line 868:             notification = self.cif.create_notification(
Line 869:                 '|virt|VM_status|' + self.id
Line 870:             )
> Please do not use this indentation style in vdsm. Do you see other code in 
Will fix the indentation.

Notification id is different for different parts of the code.

It is not internal format.
Line 871:             notification.emit(**{self.id: value})
Line 872:             if self._lastStatus == vmstatus.DOWN:
Line 873:                 self.log.warning(
Line 874:                     'trying to set state to %s when already Down',


-- 
To view, visit https://gerrit.ovirt.org/38937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I746299f9f1e2f49831a05072f19af1d242796276
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list