Change in vdsm[master]: stomp: subscription cleanup when connection lost
nsoffer at redhat.com
nsoffer at redhat.com
Tue May 19 20:17:56 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: stomp: subscription cleanup when connection lost
......................................................................
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/39969/10/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 79: self._outbox.add_last(frame)
Line 80:
Line 81: def remove_subscriptions(self):
Line 82: for sub in self._sub_ids.itervalues():
Line 83: self._remove_subscription(sub)
Can _sub_ids change while you iterate over it? Is this object accessed by multiple threads?
Line 84:
Line 85: self._sub_ids.clear()
Line 86:
Line 87: def _cmd_connect(self, dispatcher, frame):
--
To view, visit https://gerrit.ovirt.org/39969
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff05e4ff9d336dbfddf80002bad5bcd0dbac697f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list