Change in vdsm[master]: sampling: less verbose debug in _getInterfaceStats

fromani at redhat.com fromani at redhat.com
Mon May 18 10:23:17 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: sampling: less verbose debug in _getInterfaceStats
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/40424/5/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 706:             txRate = 100.0 * thisTx / interval / ifrate / Mbps2Bps
Line 707:             if txRate > 100 or rxRate > 100:
Line 708:                 txRate = min(txRate, 100.0)
Line 709:                 rxRate = min(rxRate, 100.0)
Line 710:                 self._log.debug('Rate above 100%%.')
> Is it indeed introduced later? Even if so, I am not sure how common is it a
It is not, because Dan explained that this case was discovered (speed link change), hence this log is no longer relevant.

I kept it anyway as cautionary move.
Line 711:             iface = hs1.interfaces[ifid]
Line 712:             stats['network'][ifid] = {'name': ifid, 'speed': str(ifrate),
Line 713:                                       'rxDropped': str(iface.rxDropped),
Line 714:                                       'txDropped': str(iface.txDropped),


-- 
To view, visit https://gerrit.ovirt.org/40424
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0a6063c9ac6f9f477a03881e32d0c3821038092f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list