Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats

fromani at redhat.com fromani at redhat.com
Mon May 18 10:21:46 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: sampling: hoststats: rationalize getInterfaceStats
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/40426/4/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

> less messy indeed! I think that since you touch get() you should delegate i
Yep, I do like that in 40429 and 40430, these are the easy parts :)

I'll add more cleanup in a later series, when I tackle some HostSample cleaning.


-- 
To view, visit https://gerrit.ovirt.org/40426
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list