Change in vdsm[master]: stomp: client side subscription

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Thu May 14 07:25:28 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: stomp: client side subscription
......................................................................


Patch Set 19:

(1 comment)

https://gerrit.ovirt.org/#/c/36368/19/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:

Line 547:         self._message_handler = message_handler
Line 548:         self._destination = destination
Line 549: 
Line 550:     def handle_message(self, frame):
Line 551:         self._message_handler(self, frame)
> message_handler can be none as far as I see.
Will provide docstring to give more understanding.
Line 552: 
Line 553:     def set_message_handler(self, handler):
Line 554:         self._message_handler = handler
Line 555: 


-- 
To view, visit https://gerrit.ovirt.org/36368
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Bronheim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list