Change in vdsm[master]: sampling: hoststats: rationalize getInterfaceStats

fromani at redhat.com fromani at redhat.com
Thu May 14 07:24:13 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: sampling: hoststats: rationalize getInterfaceStats
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/40426/3/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 608:         stats = {
Line 609:             'cpuUser': 0.0,
Line 610:             'cpuSys': 0.0,
Line 611:             'cpuIdle': 100.0,
Line 612:             'rxRate': 0.0,
> I can live with taking the rxRate/txRate junk out to here, but please comme
Done
Line 613:             'txRate': 0.0,
Line 614:             'cpuSysVdsmd': 0.0,
Line 615:             'cpuUserVdsmd': 0.0,
Line 616:             'elapsedTime': int(time.time() - self.startTime)


Line 686:         Compile and return a dict containing the stats.
Line 687: 
Line 688:         :returns: a dict that with the following keys:
Line 689: 
Line 690:             * cpuUser
> comment is stale
Done
Line 691:             * cpuSys
Line 692:             * cpuIdle
Line 693:             * rxRate
Line 694:             * txRate


-- 
To view, visit https://gerrit.ovirt.org/40426
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list