Change in vdsm[master]: virt: keep libvirt's <driver> element

phoracek at redhat.com phoracek at redhat.com
Thu Mar 26 10:21:28 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: virt: keep libvirt's <driver> element
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/39034/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4506:                     nic.name = name
Line 4507:                     nic.alias = alias
Line 4508:                     nic.address = address
Line 4509:                     nic.linkActive = linkActive
Line 4510:                     if driver:
> Can we ever not have this? Why?
x.getElementsByTagName('driver') could report [] when there is no <driver> element reported. In this case we skip this assignment.
Line 4511:                         nic.driver = driver
Line 4512:             # Update vm's conf with address for known nic devices
Line 4513:             knownDev = False
Line 4514:             for dev in self.conf['devices']:


-- 
To view, visit https://gerrit.ovirt.org/39034
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list