Change in vdsm[master]: virt: keep libvirt's <driver> element

fromani at redhat.com fromani at redhat.com
Thu Mar 26 10:11:20 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: keep libvirt's <driver> element
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/39034/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4516:                         dev['macAddr'].lower() == mac.lower()):
Line 4517:                     dev['address'] = address
Line 4518:                     dev['alias'] = alias
Line 4519:                     dev['name'] = name
Line 4520:                     dev['linkActive'] = linkActive
please add a short comment to remind us why we don't need 'driver' here.
Line 4521:                     knownDev = True
Line 4522:             # Add unknown nic device to vm's conf
Line 4523:             if not knownDev:
Line 4524:                 nicDev = {'type': hwclass.NIC,


-- 
To view, visit https://gerrit.ovirt.org/39034
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list