Change in vdsm[master]: storage: introducing vdsm-dump-chains script

nsoffer at redhat.com nsoffer at redhat.com
Sun Mar 22 20:09:41 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: storage: introducing vdsm-dump-chains script
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/38281/7/client/vdsm_dump_chains.py
File client/vdsm_dump_chains.py:

Line 124:     for img_uuid in images_uuids:
Line 125:         volumes = _get_volumes_for_image(server, img_uuid, sd_uuid, sp_uuid)
Line 126: 
Line 127:         # to avoid 'double parent' bug here we don't use a dictionary
Line 128:         volumes_children = []  # [(parent_vol_uuid, child_vol_uuid),]
> too long to my taste (also, children are _direct_ descendants, which is mor
Ok
Line 129: 
Line 130:         for vol_uuid in volumes:
Line 131:             vol_info = _get_vol_info(server, vol_uuid, img_uuid, sd_uuid,
Line 132:                                      sp_uuid)


-- 
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vladik Romanovsky <vladik.romanovsky at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list