Change in vdsm[master]: storage: introducing vdsm-dump-chains script

nsoffer at redhat.com nsoffer at redhat.com
Sun Mar 22 20:08:29 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: storage: introducing vdsm-dump-chains script
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/38281/7/client/vdsm_dump_chains.py
File client/vdsm_dump_chains.py:

Line 137: 
Line 138:         try:
Line 139:             image_chains[img_uuid] = _get_volume_chain(volumes_children)
Line 140:         except ChainError as e:
Line 141:             _write_error_and_exit(str(e) + ' img_uuid:%s' % (img_uuid,))
> Ok, _get_volume_chain will return a list of errors that will be printed in 
I would not return here another list of errors. If you want to return the errors and print them later, we should return a dict of objects, which can be either a valid image with a chain of volumes, or an invalid image with an error describing why it is invalid. The printing code should know how to handle both types.

If you don't have time for this, I'm ok with logging the error here and printing valid chains later.
Line 142: 
Line 143:     return image_chains, volumes_info
Line 144: 
Line 145: 


-- 
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vladik Romanovsky <vladik.romanovsky at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list