Change in vdsm[master]: stomp: server side subscriptions

fromani at redhat.com fromani at redhat.com
Fri Mar 20 08:19:12 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: stomp: server side subscriptions
......................................................................


Patch Set 9:

(1 comment)

VERY initial review

https://gerrit.ovirt.org/#/c/38451/9/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:

Line 126:             subs = self._sub_dests[destination]
Line 127:         except KeyError:
Line 128:             self._sub_dests[destination] = [subscription]
Line 129:         else:
Line 130:             subs.append(subscription)
you may want to try defaultdict to simplify this code.
Line 131: 
Line 132:         self._sub_ids[sub_id] = subscription
Line 133: 
Line 134:     def _send_error(self, msg, connection):


-- 
To view, visit https://gerrit.ovirt.org/38451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list